test: improve test-fs-access error validation #10988
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
test
cjihrig
approved these changes
Jan 25, 2017
mscdex
added
fs
Trott
reviewed
Jan 25, 2017
test/parallel/test-fs-access.js
Outdated
| @@ -92,15 +92,15 @@ fs.access(readOnlyFile, fs.W_OK, common.mustCall((err) => { | |||
|
|
|||
| assert.throws(() => { | |||
| fs.access(100, fs.F_OK, (err) => {}); | |||
|
Nit: While we're in here refactoring, maybe change the rocket function on lines 117-119 from this: (err) => {
return err.code === 'ENOENT' && err.path === doesNotExist;
}...to this?: (err) => (err.code === 'ENOENT' && err.path === doesNotExist)Both styles show up in our code base, but the latter (no unnecessary braces + return) is far more common and I'd like to see things inch towards a common style that can then be enforced by a lint rule. |
lpinca
approved these changes
Jan 25, 2017
jasnell
approved these changes
Jan 27, 2017
use better RegExp to validate the errors in assert.throws
edsadr
force-pushed
the
fs-access-error
branch
from
cefca82
to
02f893e
Compare
|
@Trott , did the Nits... sorry it took a little bit... had a hard week |
|
Closing this one in favor of #11087 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use better RegExp to validate the errors in assert.throws
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test